Repository navigation
fix: take the package, image and chart version from the release tag - #45
Merged
Merged
Conversation
Releases are tagged after merge, so no committed file could track them and everything reported 0.1.0. Read the version from git tags, pass it into the image build, and package the chart at the tag in the release workflow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The package, the API and the Helm chart all reported
0.1.0while releases were atv0.17.0. Nothing could keep them in step, because releases are tagged by a workflow after merge and no file is edited to cut one.How
The release tag is now the only version:
hatch-vcs);llm_router.__version__and the API's reported version read it from the installed package.0.0.0rather than guessing.--versionand--app-versionset to the tag and attaches the.tgzto the GitHub release..gitattributesfixes line endings to LF, so generated files compare equal on Windows and Linux.Verified locally
0.17.1.dev0(one commit pastv0.17.0).docker build --build-arg VERSION=0.17.1reports0.17.1; without the argument,0.0.0.helm package --version 0.17.1 --app-version 0.17.1producesllm-routing-0.17.1.tgz.Limits
0.17.0-1-gabc1234), not as the tag about to be cut.🤖 Generated with Claude Code